Patedam/Juliet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: Patedam:0d93cd9e6d199980e82de0f0462895cd6bd47544
Branches Tags
Patedam:main
..
compare: Patedam:a2d9980dc8beac75bd7ebced542081466cc70133
Branches Tags
Patedam:main

2 Commits
0d93cd9e6d ... a2d9980dc8

Author SHA1 Message Date
Patedam
a2d9980dc8 Adding a comment on ID3D12InfoQueue1 that are apparently only available on Win11 2025-03-11 22:47:45 -04:00
Patedam
df870b717e Remove useless code in dx12 debug layer initialization 2025-03-11 22:46:49 -04:00
1 changed files with 5 additions and 12 deletions
Expand all files Collapse all files

17
Juliet/src/Graphics/D3D12/D3D12GraphicsDevice.cpp
View File

@@ -194,7 +194,7 @@ namespace Juliet::D3D12
bool InitializeD3D12DebugInfoQueue(NonNullPtr<D3D12Driver> driver) bool InitializeD3D12DebugInfoQueue(NonNullPtr<D3D12Driver> driver)
{ {
ID3D12InfoQueue* infoQueue = NULL; ID3D12InfoQueue* infoQueue = nullptr;
D3D12_MESSAGE_SEVERITY severities[] = { D3D12_MESSAGE_SEVERITY_INFO }; D3D12_MESSAGE_SEVERITY severities[] = { D3D12_MESSAGE_SEVERITY_INFO };
HRESULT result = HRESULT result =
@@ -260,22 +260,15 @@ namespace Juliet::D3D12
void InitializeD3D12DebugInfoLogger(NonNullPtr<D3D12Driver> driver) void InitializeD3D12DebugInfoLogger(NonNullPtr<D3D12Driver> driver)
{ {
ID3D12InfoQueue* infoQueue = NULL; // Only supported on Win 11 apparently
HRESULT result = ID3D12InfoQueue1* infoQueue = nullptr;
ID3D12Device5_QueryInterface(driver->D3D12Device, IID_ID3D12InfoQueue, reinterpret_cast<void**>(&infoQueue)); HRESULT result = ID3D12Device5_QueryInterface(driver->D3D12Device, IID_ID3D12InfoQueue1, reinterpret_cast<void**>(&infoQueue));
if (FAILED(result))
{
LogError(driver, "Failed to get ID3D12InfoQueue", result);
return;
}
ID3D12InfoQueue1* infoQueue1 = nullptr;
result = ID3D12Device5_QueryInterface(driver->D3D12Device, IID_ID3D12InfoQueue1, reinterpret_cast<void**>(&infoQueue1));
if (FAILED(result)) if (FAILED(result))
{ {
return; return;
} }
ID3D12InfoQueue1_RegisterMessageCallback(infoQueue1, OnD3D12DebugInfoMsg, D3D12_MESSAGE_CALLBACK_FLAG_NONE, NULL, NULL); ID3D12InfoQueue1_RegisterMessageCallback(infoQueue, OnD3D12DebugInfoMsg, D3D12_MESSAGE_CALLBACK_FLAG_NONE, NULL, NULL);
ID3D12InfoQueue1_Release(infoQueue); ID3D12InfoQueue1_Release(infoQueue);
} }
#endif #endif